-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTLCSS Control Directive Fix + Source Maps #68669
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @SmushyTaco! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
@shail-mehta all tests have passed, could we merge this soon? |
@gziolo would you mind reviewing this so we can merge? Everything should be good to go. Thanks. |
@gziolo @ntwb @nerrad @ajitbohra @ryanwelcher @t-hamano this PR has been ready to merge for a month now and is important for Arabic speakers and other people with native languages that are right to left. Could this please be reviewed and merged soon? Thanks. |
What?
This PR fixes #68364 to allow for the proper use of control directives. It stops the moving of comments and removal of comments from breaking RTLCSS control directives. It also deletes the bundled
rtlcss-webpack-plugin
in favor of this fork I created which has source map support and is written in TypeScript.Why?
RTLCSS control directives use comments and if those comments are removed or moved, this will cause this to not function properly. See #68364 for more information.
How?
The issue is addressed by removing all comments only after RTLCSS control directives are processed. This is done by processing
cssnano
changes through it's proper webpack plugin.Testing Instructions
Build this SCSS code:
RTLCSS control directives will be correctly applied.
Testing Instructions for Keyboard
Not applicable.
Screenshots or screencast
Not applicable.