-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve display of error returned from the REST API when an unsupported image type is uploaded #68788
base: trunk
Are you sure you want to change the base?
Improve display of error returned from the REST API when an unsupported image type is uploaded #68788
Conversation
Unfortunately, this approach leads to a flash of the image showing before the error is received and displayed: upload.demo.mp4 |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
I have removed the Rest API change here leaving only the improved error handling. Instead I will add the Rest error directly in core in WordPress/wordpress-develop#8322, the change here improves the error display when the mime type is not supported. Error beforeError afterScreencastupload.error.w.gb.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @adamsilverstein!
Testing