Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style book: Change displayed colors per row to six #69165

Open
hanneslsm opened this issue Feb 12, 2025 · 4 comments
Open

Style book: Change displayed colors per row to six #69165

hanneslsm opened this issue Feb 12, 2025 · 4 comments
Labels
[Feature] Style Book Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@hanneslsm
Copy link

What problem does this address?

This issue is similar to #69162 but is about the style book

I created a sophisticated design system for the themes I build for my clients.
One important part is the color system, which uses six colors per section (base, contrast, brand, accent, utils).
I'm always using six colors per category because that's one row in the every color palette component in the editor. See:
Image

In the style book (on the right) only four colors are displayed per row, breaking this experience (and I don't see an argue to only use four instead of six).
I cannot say why in my screenshot it's currently greyed out:
Image

What is your proposed solution?

Change the displayed colors per row in the Style Book to 6 to ensure consistency across the whole editor.

@SainathPoojary
Copy link
Contributor

Hey @hanneslsm,

I have looked into how we can display six colors per row. Here is the current implementation. If this aligns with the design standards, I would like to proceed with opening a PR. Please let me know your thoughts.

2025-02-13.10-15-20.mp4

cc: @t-hamano

@hanneslsm
Copy link
Author

hanneslsm commented Feb 13, 2025

Please let me know your thoughts.

Thanks! I think this looks fantastic and much more clearer than four colors per row. Looking forward to your PR :)

@t-hamano
Copy link
Contributor

I don't have a strong opinion on the number of color columns, but we can see some discussion on the number of columns here: #67597 (comment)

Additionally, it's worth noting that in the comments, there was feedback that the colors should be in four columns: #67546 (comment)

cc @WordPress/gutenberg-design

@t-hamano t-hamano added Needs Design Feedback Needs general design feedback. [Feature] Style Book labels Feb 13, 2025
@hanneslsm
Copy link
Author

Thanks @t-hamano for the links.

If I see it correctly the context of the discussion of #67597 (comment) is that it was two previously and then changed to four. It makes sense to have two or four on mobile, but on desktop we could go to six.
Same with #67546 (comment) - the four just seems random to me.
With six, we would have at least consistency with the color palette component in the editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Style Book Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants