Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deployment approval for nuget push #34

Open
FelixS90 opened this issue Jun 6, 2024 · 0 comments
Open

Use deployment approval for nuget push #34

FelixS90 opened this issue Jun 6, 2024 · 0 comments

Comments

@FelixS90
Copy link
Collaborator

FelixS90 commented Jun 6, 2024

Is your feature request related to a problem? Please describe.
With #29, there is no additional deployment check prior to publishing the package to nuget.org (not in effect until NUGETAPI_KEY is set as either a repository or an environment secret).

Describe the solution you'd like
As a follow-up to #29, I suggest Using environments for deployment - GitHub Enterprise Cloud Docs].

Describe alternatives you've considered
None

Additional context
This should be ideally combined with ID Prefix Reservation | Microsoft Learn.

As a reference, we can look at https://github.com/ZEISS/pylibczirw (publishing to PyPI). Here, we also make use of conventional/angular commit message style and auto-version bumping based on tags derived from the commit message - similar to how it is proposed with [deploy-nuget] in #29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant