Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTN17: Host fallback #225

Closed
ably-sync-bot opened this issue Nov 13, 2020 · 6 comments · Fixed by #359 or #657
Closed

RTN17: Host fallback #225

ably-sync-bot opened this issue Nov 13, 2020 · 6 comments · Fixed by #359 or #657
Assignees
@sacOO7
Labels
enhancement New feature or improved functionality.

Comments

@ably-sync-bot
Copy link

ably-sync-bot commented Nov 13, 2020 •
edited by sync-by-unito bot
Loading

Write spec tests for RTN17, ensure they pass and that the affected API conforms to the 1.2 API design.

┆Issue is synchronized with this Jira Task by Unito
@sacOO7 sacOO7 mentioned this issue May 17, 2021
Closed
@sacOO7
Copy link
Collaborator

sacOO7 commented May 17, 2021 •
edited
Loading

Seems current realtime implementation does not support fallback hosts in the first place, we need to write custom implementation to calculate fallback hosts ( Both for rest and realtime).
We might have to refactor current fallback implementation for REST. Since, realtime and rest fallback host's are related to each other

@sacOO7
Copy link
Collaborator

sacOO7 commented May 17, 2021

This issue is also dependent on env. fallbacks which was merged sometime back in master. #268

@sacOO7
Copy link
Collaborator

sacOO7 commented May 24, 2021

Going through the code again, seems it's also dependent on REST HOST FALLBACK, we need to refactor that code, so it can be reused for RTN17.

@QuintinWillison QuintinWillison linked a pull request Jun 24, 2021 that will close this issue
REST + REALTIME Fallback #316
Closed
@sacOO7 sacOO7 mentioned this issue Jul 13, 2021
Merged
@Rosalita Rosalita added the tests label May 13, 2022
@QuintinWillison QuintinWillison added testing Includes all kinds of automated tests, the way that we run them and the infrastructure around them. and removed tests labels Dec 6, 2022
@sacOO7 sacOO7 self-assigned this Jan 19, 2024
@sacOO7
Copy link
Collaborator

sacOO7 commented Jan 19, 2024

This needs to be fixed properly as per spec!
Currently, we don't support proper fallback strategy for rest and realtime

@sacOO7
Copy link
Collaborator

sacOO7 commented Feb 16, 2024

Missing host fallback can surely cause issues for IOT based apps when one of the instance is down : (

@sacOO7 sacOO7 mentioned this issue Feb 16, 2024
Draft
@sacOO7 sacOO7 added enhancement New feature or improved functionality. and removed testing Includes all kinds of automated tests, the way that we run them and the infrastructure around them. labels Feb 20, 2024
@sacOO7
Copy link
Collaborator

sacOO7 commented Jul 29, 2024

Include #605 as a part of the fix

@sacOO7 sacOO7 mentioned this issue Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sacOO7 sacOO7

Labels
enhancement New feature or improved functionality.
Milestone
No milestone
5 participants
@QuintinWillison @Rosalita @sacOO7 @jamienewcomb @ably-sync-bot