-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pod lifecycle options #463
Comments
@c-thiel Sounds like an interesting idea, what do you think the values could look like? |
@thesuperzapper in the values.yaml I would simply add an empty lifecycle: {} option to all components. |
@c-thiel do you want to create a PR for this feature? |
Hi, how's it going, is there a possibility of this functionality being added in the future? My team has come across this issue where we want to copy some file from a shared volume to a path on the container and run some extra commands after using a postStart lifecycle hook. But currently aren't able to do so @thesuperzapper without using the stringOverride which makes it difficult to figure out how to get the pod spec right based on the the setup we currently have now |
Went and created the PR here @thesuperzapper 🤝 |
@iSWATxJOKERi thanks for the PR, I will take a look at it. |
@iSWATxJOKERi @c-thiel I have made a large comment in #653 (comment) that explains my thoughts around how we might implement a value to allow users to run scripts postStart or preStop. |
What is your feature request?
In the Chart we currently don't have an option to add a lifecycle to the pods.
These lifecycle hooks can be useful in a number of situations where we need to patch small parts of the pod.
An example could be:
To give a concrete example, I am currently facing this issue apache/airflow#8212.
To fix this I need to patch a single file in the container. I could of course go ahead and build my custom container - having a lifecycle hook would be very simple though.
Implementation should be really simple and straight forward - just forwarding whatever the user specifies in the values.yaml.
It would be good to have this, as anything else, once globally and additionaly an option to overwrite for the individual components.
The text was updated successfully, but these errors were encountered: