Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse frameio infra for non-frame io #246

Open
iboB opened this issue Jan 30, 2025 · 1 comment
Open

Reuse frameio infra for non-frame io #246

iboB opened this issue Jan 30, 2025 · 1 comment
Assignees
Labels
frameio Frame I/O. Sessions. Streams rnd Research and development

Comments

@iboB
Copy link
Member

iboB commented Jan 30, 2025

I did think of this while writing frameio, but now when working on acord, it's becoming increasingly obvious that reusing at the least of all channels, would be a good idea when moving data between WebSocket buffers and frames.

Templates are the obvious answer, but we can't make use of virtual functions in such a case as the vtables and type info would be all broken and the address sanitizer will go crazy... well we could, but we would have to forget about asan, which is a bad idea.

I'll have to think of something here...

@iboB iboB added frameio Frame I/O. Sessions. Streams rnd Research and development labels Jan 30, 2025
@iboB iboB self-assigned this Jan 30, 2025
@iboB
Copy link
Member Author

iboB commented Jan 30, 2025

The alternative here is to make ac::Frame so lightweight, that this doesn't matter. Then we could convert frames at io level without burdening the io execution too much.

Let's see where #227 takes us, and then we'll reprioritize this.

Meanwhile we'll do the "bad" thing and burden io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frameio Frame I/O. Sessions. Streams rnd Research and development
Projects
Status: Todo
Development

No branches or pull requests

1 participant