Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with setting appex extension on add target #105

Open
ajnrajeev opened this issue Oct 17, 2016 · 0 comments
Open

Issue with setting appex extension on add target #105

ajnrajeev opened this issue Oct 17, 2016 · 0 comments

Comments

@ajnrajeev
Copy link

Hi,
I am using version": "0.8.9". I was adding a target using addTarget(tgtNameStr, 'app_extension'), but the resultant target is set as .undefined.
It looks like the function defaultExtension is creating an issue in pbxFile.js

var filetype = fileRef.lastKnownFileType || fileRef.explicitFileType;

This is settings filetype to unknown since fileRef.lastKnownFileType gets set as such in pbxFile().
After changing the order here, to pick explicitFileType first if present, the following condition created an issue

if(FILETYPE_BY_EXTENSION[unquoted(extension)] === filetype )

because FILETYPE_BY_EXTENSION[unquoted(extension)] was evaluating to wrapper.app-extension whereas filetype was "wrapper.app-extension", with the quotes.

It is working for me after I made 2 changes

var filetype = fileRef.explicitFileType || fileRef.lastKnownFileType;

if(FILETYPE_BY_EXTENSION[unquoted(extension)] === unquoted(filetype) )

Not sure if this is the right way to handle this since the function is a common one. Please take a look.

Regards
Anjana

jrschifa added a commit to RyverApp/node-xcode that referenced this issue Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant