Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addLocalizationVariantGroup results in 'undefined' comment #120

Open
WarTech9 opened this issue Jan 6, 2017 · 1 comment
Open

addLocalizationVariantGroup results in 'undefined' comment #120

WarTech9 opened this issue Jan 6, 2017 · 1 comment

Comments

@WarTech9
Copy link
Contributor

WarTech9 commented Jan 6, 2017

Adding localization variant groups always adds groups with comment "undefined". For example, I end up with a PBXBuildFile section entry like this:

 4815039DEE524DBD9A7F16E8 /* Localizable.strings in undefined */ = {isa = PBXBuildFile; fileRef = E651D27D6DE74EDFB6FCD625 /* Localizable.strings */; };

Looks like the cause of this is pbxProject.addLocalizationVariantGroup: line 1864

Here, the variant group object is created without a group. This object is then passed in to this.addToPbxBuildFileSection(localizationVariantGroup). This then passes the group into pbxBuildFileComment(file), which in turn calls longComment(file), which sets the comment for this entry.
longComment returns f("%s in %s", file.basename, file.group) as file comment. Thus, not setting the group property when the variant group is created results in all variant groups being created with this method having undefined comment.

The group property in this case refers to the build phase. Since localized resources are always added to the 'Resources' build phase, setting that when the variant group is being created should fix this issue.

@imhotep
Copy link
Collaborator

imhotep commented Jan 25, 2017

@innovative1 Could you send a pull request for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants