Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addStaticLibrary problem #91

Open
aylarov opened this issue May 13, 2016 · 4 comments
Open

addStaticLibrary problem #91

aylarov opened this issue May 13, 2016 · 4 comments

Comments

@aylarov
Copy link

aylarov commented May 13, 2016

Hi, I've been trying to use the addStaticLibrary func and had some issues with it:

  1. I'm not sure about if (this.hasFile(file.path)) return false; code, since if the lib exists the function just returns false , if I change it to if (!this.hasFile(file.path)) return false; then
  2. In addToLibrarySearchPaths function there is the following code:
    if (unquote(buildSettings['PRODUCT_NAME']) != this.productName) continue;

in case of React Native iOS project (I've added fhe file) , this.productName is always $(TARGET_NAME) and continue doesn't happen only for the test target, while happens for the main target, so library isn't added to the main target Library Search Path.

project.txt

@grigoryvp
Copy link

@grigoryvp
Copy link

Bounty increased to $100

@aylarov
Copy link
Author

aylarov commented Jul 6, 2016

Ok, I figured out the problem productName getter returns the first found PRODUCT_NAME from configurations, which is $(TARGET_NAME) in case of React Native project and refers to Test target. I will modify addToLibrarySearchPaths function to add path to lib search paths for all targets and make pull request.

@aylarov
Copy link
Author

aylarov commented Jul 18, 2016

@imhotep , please let me know what's required to have this in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants