getBuildProperty: get from default or specific build of first target #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change the
getBuildProperty
method would iterate over alltargets and their build configurations without an early exit when the
property was found - that sometimes lead to having the value of a build
property from a later project.
After this change the
getBuildProperty
method will search through allbuildConfigurations (or a single one, if specified) of the first project
target and return as soon as the requested property has been found.
This PR can also be used as basis for follow-up PRs, for example: The
productName
getter can use this internally to get thePRODUCT_NAME
of the correct target. (which in turn would fix: #91 / #99)
This PR would probably make this workaround in react-native obsolete.