Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator: Initial implementation #194

Open
4 tasks
schlessera opened this issue May 13, 2021 · 3 comments
Open
4 tasks

Validator: Initial implementation #194

schlessera opened this issue May 13, 2021 · 3 comments

Comments

@schlessera
Copy link
Collaborator

The AMP Toolbox should have a full PHP implementation of the AMP validator

@westonruter
Copy link
Member

Interesting. The JavaScript implementation of the validator is being deprecated in favor of a WASM version which reuses the C++ implementation: ampproject/amphtml#36110

@schlessera
Copy link
Collaborator Author

Nice, now that I've ported the JS HTML Parser... :/

I'll go through the C++ code to see what needs adapting then.

@westonruter
Copy link
Member

I believe they have had feature parity until now, so hopefully there's nothing that needs to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants