Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when clicking on picture-in-picture mode #50

Open
Alseidon opened this issue Apr 4, 2022 · 2 comments
Open

Crash when clicking on picture-in-picture mode #50

Alseidon opened this issue Apr 4, 2022 · 2 comments

Comments

@Alseidon
Copy link

Alseidon commented Apr 4, 2022

Not a big deal, but clicking on Picture-in-Picture mode when the extension is enabled and a video is playing crashes Firefox. Maybe disable the PIP button when the extension is enabled (if this is possible) ?

@NathanJRollins
Copy link
Contributor

NathanJRollins commented Apr 5, 2022

I can't reproduce this on Win10. The fact that it crashes all of Firefox is odd - perhaps a clean install of Firefox would help, as recommended on Firefox's own crash information page. There's a lot of other great relevant information on that page as well.

Hiding the element is certainly possible, however. If you mean the miniplayer button, its CSS class is "ytp-miniplayer-button". A bit of simple CSS à-la:
.ytp-miniplayer-button { display: none !important; }
eliminates it nicely enough on the Desktop version, if you need to hide it for yourself (:

@Alseidon
Copy link
Author

Alseidon commented Apr 6, 2022

I am not an admin on my system, but I will try to reproduce this at home, with a clean install. For the record, I was using Firefox 98.0.2 (64-bit) on Ubuntu 20.04.3.

It doesn't bother me at all, just thought it could be a minor issue for some people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants