Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: fix TypeError in HelpfulArgumentParser for python 3.12.8 and 3.13.1 #15692

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

cli: fix TypeError in HelpfulArgumentParser for python 3.12.8 and 3.13.1 #15692

wants to merge 1 commit into from
+9 −2

Conversation

mhassan1
Copy link

@mhassan1 mhassan1 commented Dec 6, 2024 •
edited
Loading

SUMMARY

This PR adds logic to HelpfulArgumentParser to handle _parse_known_args with either 3 (Python 3.12.7 and below and 3.13.0) or 4 (Python 3.12.8 and 3.13.1 and above) positional arguments.

Resolves #15687.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • CLI
AWX VERSION
awx: 0.1.dev34249+g91bb012
ADDITIONAL INFORMATION

N/A

@mhassan1 mhassan1 force-pushed the typeerror-py3.13.1 branch from 983d919 to b88d179 Compare January 3, 2025 15:41
@mhassan1 mhassan1 changed the title cli: fix TypeError in HelpfulArgumentParser for python 3.13.1 cli: fix TypeError in HelpfulArgumentParser for python 3.12.8 and 3.13.1 Jan 3, 2025
@mhassan1
Copy link
Author

mhassan1 commented Jan 3, 2025

@AlanCoding Please take a look, when you have a moment. Thanks.

@mhassan1 mhassan1 force-pushed the typeerror-py3.13.1 branch from b88d179 to 975df2b Compare January 3, 2025 15:47
@djyasin
Copy link
Member

djyasin commented Jan 29, 2025

Hi @mhassan1! Thank you for your contribution. We have updated your branch so that we can run our CI Checks on this.

@codecov Codecov
Copy link

codecov bot commented Jan 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.25%. Comparing base (c418bc0) to head (013d43b).
Report is 2 commits behind head on devel.

✅ All tests successful. No failed tests found.

❌ Your project check has failed because the head coverage (75.25%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mhassan1
Copy link
Author

@djyasin I have pushed up a linting fix. I'm not sure what to do about the Code Coverage violation, since it's related to Python version; any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community component:cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWX CLI crashes with Python 3.12.8 and 3.13.1
2 participants
@mhassan1 @djyasin