Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add your own ditado #6

Open
antonioalmeida opened this issue Oct 5, 2020 · 8 comments
Open

Add your own ditado #6

antonioalmeida opened this issue Oct 5, 2020 · 8 comments
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@antonioalmeida
Copy link
Owner

Add your own ditado to the collection!

As per the project's README.me:

  • Fork this repo and edit ditados.json;
  • Add a ditado, including what it means under the meaning field:
{
   "ditados":[
      (...)
      {
         "content":"Your ditado",
         "meaning":"What it means"
      }
   ]
}
  • Submit a PR and celebrate 🎉
@antonioalmeida antonioalmeida added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 5, 2020
@brunoromeiro
Copy link
Contributor

I can help you! Assign to me.

@antonioalmeida
Copy link
Owner Author

@brunoromeiro I'm keeping this unasigned, meaning everyone who wants to can add their own. Just create a PR and submit it 😄

@brunoromeiro
Copy link
Contributor

@antonioalmeida can it be in any language? Like our Portuguese?

@antonioalmeida
Copy link
Owner Author

@brunoromeiro that is the whole point. Take a look at ditados.json

@LuizHAP
Copy link
Contributor

LuizHAP commented Oct 5, 2020

don't forget to change the PR with this recomendation (https://hacktoberfest.digitalocean.com/hacktoberfest-update)

@LuizHAP
Copy link
Contributor

LuizHAP commented Oct 6, 2020

@antonioalmeida dont forget to apply hacktoberfest-accepted labels to pull requests you want to accept.

@vnscosta vnscosta mentioned this issue Oct 6, 2020
@antonioalmeida
Copy link
Owner Author

@LuizHAP the repository is tagged as Hacktoberfest, I don't need to add an extra PR tag.

As per Hacktoberfest's website:

PRs count if: 
Submitted during the month of October AND ( 
  The PR is labelled as hacktoberfest-accepted by a maintainer OR 
  Submitted in a repo with the hacktoberfest topic AND ( 
    The PR is merged OR 
    The PR has been approved 
  ) 
)

antonioalmeida pushed a commit that referenced this issue Oct 16, 2022
* New portuguese sayings

* fix with comma
@c137santos
Copy link
Contributor

Sorry for forgetting. I corrected it, can you accept me with the hacktown tag? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants