Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-8678] Fix jar name on macos #8679

Merged
merged 2 commits into from
Feb 8, 2025
Merged

[GLUTEN-8678] Fix jar name on macos #8679

merged 2 commits into from
Feb 8, 2025

Conversation

marin-ma
Copy link
Contributor

@marin-ma marin-ma commented Feb 6, 2025 •
edited by Yohahaha
Loading

After this fix, the jar name on macOS will be like:
gluten-velox-bundle-spark3.5_2.12-darwin_aarch64-1.4.0-SNAPSHOT.jar
gluten-velox-bundle-spark3.5_2.12-darwin_x86_64-1.4.0-SNAPSHOT.jar

Fixes: #8678

@github-actions github-actions bot added the CORE works for Gluten Core label Feb 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

#8678

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

Run Gluten Clickhouse CI on x86

zhztheplayer
zhztheplayer reviewed Feb 7, 2025
View reviewed changes
pom.xml Outdated
@@ -978,6 +985,7 @@
<properties>
<platform>linux</platform>
<arch>amd64</arch>
<os.full.name>${os.detected.release}_${os.detected.release.version}_${os.detected.arch}</os.full.name>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we use <os.full.name>${platform}_${arch}</os.full.name> for linux as well?

Given #6942 was merged later than #4529

cc @Yohahaha

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both ok to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marin-ma Would you help make the change? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhztheplayer Updated. Thanks!

@zhztheplayer
Copy link
Member

(off-topic perhaps) I assume one purpose of #6942 was to make one fat jar support multiple archs and platforms. So in future we might completely remove the arch / platform marks in the jar name? cc @wForget

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

Run Gluten Clickhouse CI on x86

@marin-ma marin-ma merged commit 9539ebf into apache:main Feb 8, 2025
51 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_02_08_2025_time.csv log/native_master_02_08_2025_fcd83db265_time.csv difference percentage
q1 11.11 10.78 -0.330 97.03%
q2 12.06 12.15 0.088 100.73%
q3 3.00 3.92 0.922 130.71%
q4 51.78 51.46 -0.321 99.38%
q5 8.32 10.46 2.138 125.70%
q6 3.87 4.42 0.552 114.27%
q7 4.83 4.68 -0.146 96.97%
q8 3.76 4.20 0.446 111.87%
q9 13.47 16.10 2.629 119.52%
q10 14.38 12.62 -1.762 87.75%
q11 28.87 26.67 -2.198 92.39%
q12 3.10 2.39 -0.711 77.05%
q13 5.86 6.17 0.308 105.25%
q14a 43.91 45.00 1.090 102.48%
q14b 41.60 41.66 0.067 100.16%
q15 3.10 3.87 0.770 124.84%
q16 4.25 4.57 0.319 107.50%
q17 6.26 5.49 -0.765 87.77%
q18 8.35 8.16 -0.185 97.79%
q19 4.41 4.13 -0.280 93.64%
q20 2.69 2.71 0.017 100.63%
q21 1.55 1.51 -0.037 97.61%
q22 2.91 2.81 -0.106 96.36%
q23a 61.19 61.86 0.665 101.09%
q23b 71.46 73.56 2.107 102.95%
q24a 73.58 73.89 0.306 100.42%
q24b 68.58 66.94 -1.640 97.61%
q25 6.12 5.05 -1.073 82.48%
q26 2.15 2.69 0.536 124.89%
q27 2.47 3.47 0.999 140.37%
q28 17.87 16.73 -1.132 93.66%
q29 7.91 8.46 0.551 106.96%
q30 5.36 5.75 0.394 107.35%
q31 8.97 7.83 -1.148 87.21%
q32 1.50 1.59 0.081 105.38%
q33 3.71 3.80 0.094 102.55%
q34 3.70 3.30 -0.400 89.18%
q35 7.49 6.93 -0.554 92.60%
q36 2.21 2.33 0.116 105.23%
q37 2.84 3.03 0.194 106.82%
q38 11.91 11.43 -0.482 95.95%
q39a 4.38 4.30 -0.072 98.35%
q39b 3.59 4.23 0.638 117.76%
q40 3.88 3.69 -0.191 95.08%
q41 0.71 0.63 -0.080 88.81%
q42 0.53 1.74 1.204 326.14%
q43 1.78 1.77 -0.000 100.00%
q44 6.28 6.14 -0.139 97.78%
q45 3.40 3.51 0.118 103.48%
q46 4.11 3.92 -0.184 95.52%
q47 10.62 11.16 0.549 105.17%
q48 3.69 3.73 0.037 100.99%
q49 5.59 5.81 0.220 103.93%
q50 17.38 17.63 0.242 101.39%
q51 7.42 7.27 -0.154 97.92%
q52 1.85 0.64 -1.207 34.78%
q53 1.72 2.07 0.350 120.28%
q54 6.08 5.88 -0.201 96.69%
q55 0.60 1.05 0.455 175.79%
q56 4.24 4.38 0.131 103.09%
q57 6.14 7.00 0.868 114.14%
q58 2.79 3.73 0.942 133.75%
q59 4.39 4.70 0.317 107.24%
q60 5.36 4.97 -0.390 92.72%
q61 3.93 4.62 0.688 117.49%
q62 3.37 2.96 -0.409 87.86%
q63 1.64 1.32 -0.324 80.24%
q64 36.84 35.49 -1.345 96.35%
q65 11.19 10.98 -0.210 98.12%
q66 2.53 3.25 0.721 128.54%
q67 58.28 58.10 -0.175 99.70%
q68 3.61 3.48 -0.130 96.41%
q69 5.21 5.15 -0.059 98.86%
q70 5.44 5.59 0.149 102.74%
q71 5.88 4.26 -1.620 72.45%
q72 20.37 21.04 0.675 103.31%
q73 2.95 2.35 -0.600 79.67%
q74 17.01 17.60 0.587 103.45%
q75 23.11 23.41 0.301 101.30%
q76 6.89 7.05 0.157 102.29%
q77 2.15 2.25 0.096 104.45%
q78 33.46 33.85 0.389 101.16%
q79 3.97 3.89 -0.079 98.00%
q80 10.79 10.58 -0.208 98.07%
q81 6.42 8.23 1.806 128.11%
q82 5.29 5.37 0.081 101.54%
q83 1.46 1.57 0.106 107.21%
q84 2.96 3.84 0.877 129.59%
q85 5.61 5.88 0.265 104.73%
q86 2.04 2.07 0.025 101.23%
q87 11.75 11.37 -0.386 96.71%
q88 15.73 15.79 0.065 100.41%
q89 2.16 2.06 -0.108 95.03%
q90 2.12 2.30 0.183 108.66%
q91 3.74 3.37 -0.365 90.24%
q92 1.87 1.90 0.030 101.60%
q93 23.46 24.22 0.761 103.24%
q94 8.48 8.44 -0.033 99.61%
q9 59.06 59.05 -0.005 99.99%
q5 2.21 1.91 -0.294 86.67%
q96 10.82 10.96 0.143 101.32%
q97 2.57 2.51 -0.055 97.88%
q98 5.07 5.54 0.467 109.21%
q99 0.72 0.44 -0.271 62.12%
total 1181.13 1188.59 7.463 100.63%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_02_08_2025_time.csv log/native_master_02_07_2025_fcd83db265_time.csv difference percentage
q1 25.34 24.61 -0.728 97.13%
q2 27.44 27.41 -0.030 99.89%
q3 32.66 33.46 0.795 102.43%
q4 27.67 27.72 0.050 100.18%
q5 59.16 62.66 3.496 105.91%
q6 9.59 9.15 -0.441 95.40%
q7 40.35 42.47 2.119 105.25%
q8 62.97 70.69 7.724 112.27%
q9 107.70 115.14 7.438 106.91%
q10 40.56 46.58 6.014 114.83%
q11 16.00 17.42 1.416 108.85%
q12 16.26 16.91 0.648 103.99%
q13 27.44 27.54 0.102 100.37%
q14 12.08 12.77 0.695 105.75%
q15 28.50 28.20 -0.294 98.97%
q16 13.34 13.50 0.168 101.26%
q17 80.44 83.33 2.883 103.58%
q18 121.44 126.04 4.599 103.79%
q19 20.66 17.19 -3.466 83.22%
q20 26.65 26.11 -0.530 98.01%
q21 195.18 197.25 2.073 101.06%
q22 10.72 10.58 -0.136 98.73%
total 1002.13 1036.73 34.594 103.45%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yohahaha Yohahaha Yohahaha left review comments

@zhztheplayer zhztheplayer zhztheplayer approved these changes

Assignees
No one assigned
Labels
CORE works for Gluten Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core] Gluten jar contains unresolved variable name when building on macOS
4 participants
@marin-ma @zhztheplayer @GlutenPerfBot @Yohahaha