Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upsert Compaction Generator: CRC mismatch robustness #13492

Closed
Tracked by #13493
tibrewalpratik17 opened this issue Jun 27, 2024 · 1 comment
Closed
Tracked by #13493

Upsert Compaction Generator: CRC mismatch robustness #13492

tibrewalpratik17 opened this issue Jun 27, 2024 · 1 comment

Comments

@tibrewalpratik17
Copy link
Contributor

During the UpsertCompactionTaskGenerator, we check whether the ZK metadata CRC of a segment matches the CRC we fetch from the validDocID bitmap response from the servers (Ref).

If a scenario is present where the CRCs do not match across replicas and we use the CRC from the validDocID bitmap response from a replica server that has not updated the ZK metadata, we will end up not considering that segment for compaction.

Tracking this issue for making this generation process more robust.

@tibrewalpratik17
Copy link
Contributor Author

This should be fixed by #13489.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant