Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tab text seems to have inconsistent vertical alignment #15

Open
balupton opened this issue Jan 16, 2017 · 2 comments
Open

tab text seems to have inconsistent vertical alignment #15

balupton opened this issue Jan 16, 2017 · 2 comments

Comments

@balupton
Copy link

screen shot 2017-01-17 at 7 44 46 am
@tj
Copy link
Member

tj commented Jan 17, 2017 •
edited
Loading

Hmm odd, thought I hid the icons (assuming that's what's messing with the line-height)

@agirton
Copy link

agirton commented Jan 17, 2017 •
edited
Loading

It looks like to remove the icon styles pseudo content needs to be an empty string. Also I don't think this selector works since the class of the tab is title icon js-icon. Happy to submit a PR to update those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tj @balupton @agirton