Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stack traces in express adapter #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix stack traces in express adapter #120

wants to merge 1 commit into from

Conversation

dennisameling
Copy link

Closes #119

Using the reproducer from the linked issue, here's the before and after results:

Before

Error: This error produces a stack trace that is incorrect.
    at eval (/Users/dennisameling/repos/vite-plugin-node-stack-bug/src/server.ts:8:9)
    at Layer.handle [as handle_request] (/Users/dennisameling/repos/vite-plugin-node-stack-bug/node_modules/express/lib/router/layer.js:95:5)
    at next (/Users/dennisameling/repos/vite-plugin-node-stack-bug/node_modules/express/lib/router/route.js:149:13)
    at Route.dispatch (/Users/dennisameling/repos/vite-plugin-node-stack-bug/node_modules/express/lib/router/route.js:119:3)
    at Layer.handle [as handle_request] (/Users/dennisameling/repos/vite-plugin-node-stack-bug/node_modules/express/lib/router/layer.js:95:5)
    at /Users/dennisameling/repos/vite-plugin-node-stack-bug/node_modules/express/lib/router/index.js:284:15
    at Function.process_params (/Users/dennisameling/repos/vite-plugin-node-stack-bug/node_modules/express/lib/router/index.js:346:12)
    at next (/Users/dennisameling/repos/vite-plugin-node-stack-bug/node_modules/express/lib/router/index.js:280:10)
    at expressInit (/Users/dennisameling/repos/vite-plugin-node-stack-bug/node_modules/express/lib/middleware/init.js:40:5)
    at Layer.handle [as handle_request] (/Users/dennisameling/repos/vite-plugin-node-stack-bug/node_modules/express/lib/router/layer.js:95:5)

After

Error: This error produces a stack trace that is incorrect.
    at /Users/dennisameling/repos/vite-plugin-node-stack-bug/src/server.ts:10:9
    at Layer.handle [as handle_request] (/Users/dennisameling/repos/vite-plugin-node-stack-bug/node_modules/express/lib/router/layer.js:95:5)
    at next (/Users/dennisameling/repos/vite-plugin-node-stack-bug/node_modules/express/lib/router/route.js:149:13)
    at Route.dispatch (/Users/dennisameling/repos/vite-plugin-node-stack-bug/node_modules/express/lib/router/route.js:119:3)
    at Layer.handle [as handle_request] (/Users/dennisameling/repos/vite-plugin-node-stack-bug/node_modules/express/lib/router/layer.js:95:5)
    at /Users/dennisameling/repos/vite-plugin-node-stack-bug/node_modules/express/lib/router/index.js:284:15
    at Function.process_params (/Users/dennisameling/repos/vite-plugin-node-stack-bug/node_modules/express/lib/router/index.js:346:12)
    at next (/Users/dennisameling/repos/vite-plugin-node-stack-bug/node_modules/express/lib/router/index.js:280:10)
    at expressInit (/Users/dennisameling/repos/vite-plugin-node-stack-bug/node_modules/express/lib/middleware/init.js:40:5)
    at Layer.handle [as handle_request] (/Users/dennisameling/repos/vite-plugin-node-stack-bug/node_modules/express/lib/router/layer.js:95:5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong stack traces in dev mode
1 participant
@dennisameling