Skip to content
This repository has been archived by the owner on Aug 5, 2021. It is now read-only.

GIL audit? #162

Open
devinrsmith opened this issue Jan 17, 2019 · 0 comments
Open

GIL audit? #162

devinrsmith opened this issue Jan 17, 2019 · 0 comments

Comments

@devinrsmith
Copy link
Contributor

I'm not an expert on the GIL / Python C api, but the documentation suggests that every single API call needs to be executed within the context of a held GIL lock: "... only the thread that has acquired the GIL may operate on Python objects or call Python/C API functions."

I've noticed a few places where the GIL isn't being acquired: Java_org_jpy_PyLib_newDict and Java_org_jpy_PyLib_copyDict (a non-exhaustive search). Should these places acquire the GIL?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant