Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urlresolver should match regardless of "query string" part of the url. #4

Open
thomasyip opened this issue Mar 12, 2014 · 2 comments
Open

Comments

@thomasyip
Copy link
Member

For example,

The following url should match:

`http://localhost/12345/?_refer=abc`

with this rule:
url('^\(?P<id>\\d{2,20})/$', 'reports.views.index')

However, it doesn't, and I need to change the rule to:
url('^\(?P<id>\\d{2,20})/.*$', 'reports.views.index')

The example (dingo-example) should be updated to add a link with query parameter. Please send pull request on both repos.

@ulion
Copy link

ulion commented Mar 12, 2014

when you match the url, why not first remove parts after '?' then do the match?

@thomasyip
Copy link
Member Author

@ulion, I think it is what should be done.

Perhaps, parse the url first and only use the path. Be careful not to break the support of optional trailing "/".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants