New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve rest api with v2 api #84

Open

patrickelectric opened this issue Nov 5, 2024 · 1 comment

Labels

Member

patrickelectric commented Nov 5, 2024

Remove type from enum based structures
e.g:

const commandMessage: Message.CommandLong = {
      type: MAVLinkType.COMMAND_LONG,
      param1: param1,
      param2: param2,
      param3: param3,
      param4: param4,
      param5: param5,
      param6: param6,
      param7: param7,
      command: {
        type: mav_command,
      },
      target_system: this.currentSystemId,
      target_component: 1,
      confirmation: 0,
    }

type should not be necessary for mav_command

The text was updated successfully, but these errors were encountered:

Member

joaoantoniocardoso commented Nov 12, 2024 •

edited

Loading

This comes from rust-mavlink, right?

The workaround on our side would be a string replacement.

joaoantoniocardoso added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment