From 0bc38bb748dfaa9ee83db5400fcc9e474e36098d Mon Sep 17 00:00:00 2001 From: claytongentry Date: Fri, 7 Feb 2025 17:34:51 -0500 Subject: [PATCH] rubocops --- lib/manifold/api/workspace.rb | 2 +- lib/manifold/terraform/workspace_configuration.rb | 4 +--- spec/manifold/api/workspace_spec.rb | 7 +++++++ spec/manifold/terraform/workspace_configuration_spec.rb | 2 +- 4 files changed, 10 insertions(+), 5 deletions(-) diff --git a/lib/manifold/api/workspace.rb b/lib/manifold/api/workspace.rb index 096e16e..1048d94 100644 --- a/lib/manifold/api/workspace.rb +++ b/lib/manifold/api/workspace.rb @@ -111,7 +111,7 @@ def generate_terraform vector_config = @vector_service.load_vector_config(vector) config.add_vector(vector_config) end - config.set_merge_config(manifold_yaml["dimensions"]&.fetch("merge", nil)) if manifold_yaml["dimensions"] + config.merge_config = manifold_yaml["dimensions"]&.fetch("merge", nil) if manifold_yaml["dimensions"] config.write(terraform_main_path) end end diff --git a/lib/manifold/terraform/workspace_configuration.rb b/lib/manifold/terraform/workspace_configuration.rb index b026364..7839125 100644 --- a/lib/manifold/terraform/workspace_configuration.rb +++ b/lib/manifold/terraform/workspace_configuration.rb @@ -17,9 +17,7 @@ def add_vector(vector_config) @vectors << vector_config end - def set_merge_config(merge_config) - @merge_config = merge_config - end + attr_writer :merge_config def as_json { diff --git a/spec/manifold/api/workspace_spec.rb b/spec/manifold/api/workspace_spec.rb index 69f3571..005662b 100644 --- a/spec/manifold/api/workspace_spec.rb +++ b/spec/manifold/api/workspace_spec.rb @@ -171,10 +171,17 @@ def configure_vector_config end def setup_workspace_files + setup_routines_directory + setup_manifold_config + end + + def setup_routines_directory Pathname.pwd.join("lib/routines").mkpath Pathname.pwd.join("lib/routines/select_pages.sql") .write("SELECT id, STRUCT(url, title) AS dimensions FROM pages") + end + def setup_manifold_config workspace.add workspace.manifold_path.write(<<~YAML) vectors: diff --git a/spec/manifold/terraform/workspace_configuration_spec.rb b/spec/manifold/terraform/workspace_configuration_spec.rb index 8e78807..161da7a 100644 --- a/spec/manifold/terraform/workspace_configuration_spec.rb +++ b/spec/manifold/terraform/workspace_configuration_spec.rb @@ -35,7 +35,7 @@ before do setup_merge_vector_config config.add_vector(vector_config) - config.set_merge_config({ "source" => "lib/routines/select_pages.sql" }) + config.merge_config = { "source" => "lib/routines/select_pages.sql" } end it "includes routine configuration" do