Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meldium import #17

Open
pandaiolo opened this issue Jul 13, 2017 · 3 comments
Open

Meldium import #17

pandaiolo opened this issue Jul 13, 2017 · 3 comments

Comments

@pandaiolo
Copy link

pandaiolo commented Jul 13, 2017

I am a former user of Meldium , which was acquired by LastPass, and closed its doors a few days ago.

I exported my data in the Meldium CSV format that appears to be different than LastPass format.

I would like to contribute this new importer feature, but I am not sure how to implement it, as I first intended to copy and modify the LastPass import PR, but the import format is extrapolated from the file extension, which does not make a lot of sense, since CSV format is not proprietary to LastPass.

Should I send a broader PR that also modifies importer's API to be more flexible in order to support current importers but not based on file extension?

Edit: the importer API I am talking about is in the main buttercup repo, but since it is an importer topic, I thought I'd better open an issue in this one

@perry-mitchell
Copy link
Member

Hi @pandaiolo - Apologies for the long delay, I was on holidays.

I exported my data in the Meldium CSV format that appears to be different than LastPass format.

Yes, I imagine that there will be many different export formats across all password managers. CSV is definitely going to be a common export format.

the import format is extrapolated from the file extension

This isn't true for this library like you said, as the index file just exports the functions to handle each type of file. Unfortunately there is an issue in the desktop app that needs amending. I'll lodge an issue there.

@perry-mitchell
Copy link
Member

I'll leave this issue as a placeholder, but the issue is not with this project.

@perry-mitchell
Copy link
Member

Thinking that this could now be a separate importer altogether.

@perry-mitchell perry-mitchell changed the title Meldium import (and possibly generic CSV) Meldium import Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants