Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViccNormalizerDataExtension should be moved to mappings #418

Open
korikuzma opened this issue Jan 20, 2025 · 2 comments · May be fixed by #425
Open

ViccNormalizerDataExtension should be moved to mappings #418

korikuzma opened this issue Jan 20, 2025 · 2 comments · May be fixed by #425
Assignees
Labels
enhancement New feature or request priority:medium Medium priority

Comments

@korikuzma
Copy link
Member

korikuzma commented Jan 20, 2025

Currently, we have the a ViccNormalizerDataExtension in MappableConcept.extensions. For Disease conceptTypes, this looks like:

{
  "name": "vicc_normalizer_data",
  "value": {
    "id": "ncit:C4035",
    "label": "Thyroid Gland Papillary Carcinoma",
    "mondo_id": "mondo:0005075"
  }
}

However, we should actually be storing these as ConceptMappings in mappings:

[
    {
        "coding": {
            "id": "doid:3908",
            "code": "DOID:3908",
            "system": "https://disease-ontology.org/?id="
        },
        "relation": "exactMatch",
        "extensions": [
            {
                "name": "from_vicc_normalizer",
                "value": true
            }
        ]
    },
    {
        "coding": {
            "id": "ncit:C2926",
            "code": "C2926",
            "label": "Lung Non-Small Cell Carcinoma",
            "system": "https://ncit.nci.nih.gov/ncitbrowser/ConceptReport.jsp?dictionary=NCI_Thesaurus&code="
        },
        "relation": "exactMatch",
        "extensions": [
            {
                "name": "from_vicc_normalizer",
                "value": true
            }
        ]
    },
    {
        "coding": {
            "id": "mondo:0005233",
            "code": "MONDO:0005233",
            "system": "http://purl.obolibrary.org/obo/mondo.owl"
        },
        "relation": "exactMatch",
        "extensions": [
            {
                "name": "from_vicc_normalizer",
                "value": true
            }
        ]
    }
]

I might need to check with @ahwagner on relation values.

@korikuzma korikuzma added enhancement New feature or request priority:medium Medium priority labels Jan 20, 2025
@korikuzma korikuzma self-assigned this Jan 20, 2025
@korikuzma
Copy link
Member Author

Need to figure out if we change relation to exact match or use what's in the normalizers

@korikuzma
Copy link
Member Author

korikuzma commented Jan 27, 2025

I realize we also need to retain if it was the merged concept ID (from priority source). Thinking of updating the extension to be:

"extensions": [
            {
                "name": "from_vicc_normalizer",
                "value": {"is_merged_identifier": True}
            }
        ]

or

"extensions": [
            {
                "name": "vicc_normalizer_merged_id",
                "value": True
            }
        ]

Where vicc_normalizer_merged_id would only be present in VICC concept mappings. I kind of like this option better because it's more compact.

@jsstevenson @katiestahl thoughts? Open to alternatives.

Update: Not sure about vicc_normalizer_merged_id since it will also include label and not just the merged concept ID... Going to go with vicc_normalizer_priority for now.

@korikuzma korikuzma linked a pull request Jan 28, 2025 that will close this issue
@korikuzma korikuzma linked a pull request Jan 28, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:medium Medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant