Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use simpler symbols if Nerd Font isn't available #14

Open
heathhenley opened this issue Jan 10, 2025 · 1 comment
Open

Use simpler symbols if Nerd Font isn't available #14

heathhenley opened this issue Jan 10, 2025 · 1 comment
Labels
component: UI Issues related to changing UI good first issue Good for newcomers priority: medium Issues with medium priority, can be worked on if there're no high priority issues type: feature New feature request

Comments

@heathhenley
Copy link
Collaborator

heathhenley commented Jan 10, 2025

From discussion here: #8 (comment)
eg:

it's probably a good idea to check for the supported font and use some alternative simpler symbols

If Hack Nerd Font Mono isn't installed, the icons for text files, folders, binary files, etc render as something like �. Seems like this would involve checking if the font is available, and if not selecting more widely supported alternatives for the icons.

Maybe there could also be a note in "About" or something to hint that you should install nerd font?

@chshersh chshersh added good first issue Good for newcomers component: UI Issues related to changing UI priority: medium Issues with medium priority, can be worked on if there're no high priority issues labels Jan 11, 2025
@chshersh
Copy link
Owner

@heathhenley Thanks for creating an issue! I can see several subtasks here:

  • Detect if the Nerd Font Mono installed (I have no idea how to do it yet, need to research)
  • Find alternative simple icons
  • Somehow parametrise the view to dynamically select icons based on the setting
  • Display a warning (this probably deserves a separate discussion on, how to display it)

Currently, all icons are written here:

let pwd_char = "\u{e5fd}"
let dir_char = "\u{f4d4}"
let empty_dir_char = "\u{f413}"
let file_char = "\u{f4a5}"

@chshersh chshersh added the type: feature New feature request label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: UI Issues related to changing UI good first issue Good for newcomers priority: medium Issues with medium priority, can be worked on if there're no high priority issues type: feature New feature request
Projects
None yet
Development

No branches or pull requests

2 participants