-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After serialization of request payload bytes, verify payload size is <100MB #32
Comments
@gabbifish |
@geota Go for it!! I'd be happy to provide PR review :) |
geota
pushed a commit
to geota/cloudflare-rs
that referenced
this issue
Sep 12, 2019
add validation method to endpoint trait. implement payload size validation for bulk write endpoint.
geota
pushed a commit
to geota/cloudflare-rs
that referenced
this issue
Sep 12, 2019
add validation method to endpoint trait. implement payload size validation for bulk write endpoint.
geota
pushed a commit
to geota/cloudflare-rs
that referenced
this issue
Sep 12, 2019
add validation method to endpoint trait. implement payload size validation for bulk write endpoint.
geota
pushed a commit
to geota/cloudflare-rs
that referenced
this issue
Sep 12, 2019
add validation method to endpoint trait. implement payload size validation for bulk write endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are certain API endpoints on the Cloudflare API that allow users to send large payloads (e.g. the Workers KV bulk upload endpoint).
The API gateway will block any payloads over 100MB in size: this means we get an
APIFailure
likeError(413, ApiErrors { other: {}, errors: [] })
. I think it could be worth introducing a general request validator function that checks for things like appropriate payload size, given that this will affect all API requests.cc @ashleymichal
The text was updated successfully, but these errors were encountered: