Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add async modifier for ProxyHttp::response_body_filter #347

Open
tqlab opened this issue Aug 8, 2024 · 1 comment · May be fixed by #525
Open

Add async modifier for ProxyHttp::response_body_filter #347

tqlab opened this issue Aug 8, 2024 · 1 comment · May be fixed by #525
Labels
enhancement New feature or request

Comments

@tqlab
Copy link

tqlab commented Aug 8, 2024

What is the problem your feature solves, or the need it fulfills?

Sometimes it is necessary to add some asynchronous operations in this method.
@drcaramelsyrup drcaramelsyrup added the enhancement New feature or request label Aug 13, 2024
@pszabop
Copy link

pszabop commented Dec 16, 2024 •
edited
Loading

Ditto here. I need to be able to call async logging functions, async requests out to external processes, etc.

No problem with request_body_filter, it's already asynchronous. This appears to be the lone hold out. Also the last thing I went to implement, so just noticed it after writing a pile of async code I call from request_body_filter that I can't call from response_body_filter (just for example, a logging function)

@gabioprisan gabioprisan linked a pull request Feb 7, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@drcaramelsyrup @tqlab @pszabop