Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Alpaka EDProducers to pass the edm::ParameterSet to base class constructor #47216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Jan 30, 2025

PR description:

This PR is a follow-up to #47028 and migrates all present Alpaka EDProducers to pass the edm::ParameterSet to their base class constructor.

Resolves cms-sw/framework-team#1189

PR validation:

Code compiles

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 30, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47216/43501

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • EventFilter/EcalRawToDigi (reconstruction)
  • EventFilter/HcalRawToDigi (reconstruction)
  • HeterogeneousCore/AlpakaCore (heterogeneous)
  • HeterogeneousCore/AlpakaTest (heterogeneous)
  • RecoLocalCalo/EcalRecProducers (reconstruction)
  • RecoLocalCalo/HGCalRecAlgos (reconstruction, upgrade)
  • RecoLocalCalo/HGCalRecProducers (reconstruction, upgrade)
  • RecoLocalCalo/HcalRecProducers (reconstruction)
  • RecoLocalTracker/SiPixelClusterizer (reconstruction)
  • RecoLocalTracker/SiPixelRecHits (reconstruction)
  • RecoParticleFlow/PFClusterProducer (reconstruction)
  • RecoParticleFlow/PFRecHitProducer (reconstruction)
  • RecoTracker/LST (reconstruction)
  • RecoTracker/PixelSeeding (reconstruction)
  • RecoVertex/BeamSpotProducer (alca, reconstruction)
  • RecoVertex/PixelVertexFinding (reconstruction)

@Moanwar, @atpathak, @cmsbuild, @consuegs, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @perrotta, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @ReyerBand, @VinInn, @VourMa, @abdoulline, @apsallid, @argiro, @bsunanda, @cseez, @denizsun, @dgulhan, @dkotlins, @edjtscott, @fabiocos, @felicepantaleo, @ferencek, @francescobrivio, @gpetruc, @hatakeyamak, @lecriste, @lgray, @mariadalfonso, @martinamalberti, @missirol, @mmarionncern, @mmusich, @mroguljic, @mtosi, @pfs, @rchatter, @rovere, @rsreds, @salimcerci, @sameasy, @seemasharmafnal, @sethzenz, @thomreis, @threus, @tocheng, @tsusa, @tvami, @vandreev11, @wang0jin, @youyingli, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 80KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e63879/44091/summary.html
COMMIT: 27e19c3
CMSSW: CMSSW_15_0_X_2025-01-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47216/44091/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@fwyzard
Copy link
Contributor

fwyzard commented Jan 31, 2025

+heterogeneous

@fwyzard
Copy link
Contributor

fwyzard commented Jan 31, 2025

enable gpu

@fwyzard
Copy link
Contributor

fwyzard commented Jan 31, 2025

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 80KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e63879/44093/summary.html
COMMIT: 27e19c3
CMSSW: CMSSW_15_0_X_2025-01-30-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47216/44093/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 53071
  • DQMHistoTests: Total failures: 871
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 52200
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 24 log files, 30 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor Author

CPU comparison differences are related to #39803 and #47071

GPU comparison differences are probably(?) the "inherent" non-reproducibility in the pixel tracking code.

@jfernan2
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment