Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo doesn't include optional modules #1

Open
jhummel opened this issue Sep 8, 2013 · 6 comments
Open

Repo doesn't include optional modules #1

jhummel opened this issue Sep 8, 2013 · 6 comments

Comments

@jhummel
Copy link

jhummel commented Sep 8, 2013

The zepto.js file contained within seems to not include the optional modules. (like touch.js). Would it make sense to include something like zepto.full.js with a build of all the modules, or just include the optional modules as separate files?

@ChrisAntaki
Copy link
Contributor

Having them as separate files would be sweet. 👍

@mislav
Copy link
Contributor

mislav commented Jul 7, 2014

👍 for separate files. However, you will need to know which modules depend on other optional modules when you manually require extra files.

@RobLoach
Copy link
Member

RobLoach commented Jul 8, 2014

Perhaps we'd have separate repositories for the modules and have components/zepto as a dependency?

@RobLoach RobLoach mentioned this issue Aug 4, 2015
@brunowego
Copy link

+1

@stereobooster
Copy link

However, you will need to know which modules depend on other optional modules when you manually require extra files.

There are different ways to address this issue. Let's discuss and decide

  1. ES6 import + rollup
  2. AMD + webpack
  3. Throw runtime exception if dependencies are missing
  4. Manual instructions in readme.md

@RobLoach
Copy link
Member

Add browserify in there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants