-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Otel support just like otelconnect-go does #988
Comments
With #982 merged, in the next release you can use an interceptor to add this functionality. I'll post an example here once the docs are updated |
@srikrsna-buf Nice! Thanks! |
We just published a preview release with support for server side interceptors: The docs for interceptors are here. |
Looking forward for the actual release! In the meantime, I'll read the docs and telling my teammates that the solution to our current issue is on its way. Thanks for the support @srikrsna-buf!!! |
Closing this issue, but feel free to re-open (or create a new issue) if needed. Thanks! |
Well, I'd like to keep it open until v1.4.0 comes out. At least, I'd like to know how long until the next release. My CTO is asking me. |
Sure, we can do that. Unsure of the release date at the moment, but I'll look into it. |
Thanks @chrispine |
Here you go, @danvergara: https://github.com/connectrpc/connect-es/releases/tag/v1.4.0 I'll close this now, but as always, reach back out or re-open if needed. Thanks! |
Thanks so much!!!!!!!!! |
Is your feature request related to a problem? Please describe.
Is there a way to add support for Open Telemetry instrumentation just like connect-go has?
The current stack of the company I work for has some apps using connect and we're in the middle of the endeavor of instrumenting the most critical apps and workflows we maintain.
Describe the solution you'd like
There's a function called
createConnectTransport
that has a field calledinterceptors
that can be used to intercept requests to add headers such astraceparent
.The request is for Connect for Node.js
Describe alternatives you've considered
Another alternative is doing that by ourselves, but we might need an example.
The text was updated successfully, but these errors were encountered: