Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otel support just like otelconnect-go does #988

Closed
danvergara opened this issue Jan 24, 2024 · 10 comments
Closed

Otel support just like otelconnect-go does #988

danvergara opened this issue Jan 24, 2024 · 10 comments
Labels
enhancement New feature or request

Comments

@danvergara
Copy link

danvergara commented Jan 24, 2024

Is your feature request related to a problem? Please describe.

Is there a way to add support for Open Telemetry instrumentation just like connect-go has?
The current stack of the company I work for has some apps using connect and we're in the middle of the endeavor of instrumenting the most critical apps and workflows we maintain.

Describe the solution you'd like
There's a function called createConnectTransport that has a field called interceptors that can be used to intercept requests to add headers such as traceparent.

The request is for Connect for Node.js

Describe alternatives you've considered
Another alternative is doing that by ourselves, but we might need an example.

@danvergara danvergara added the enhancement New feature or request label Jan 24, 2024
@srikrsna-buf
Copy link
Member

Another alternative is doing that by ourselves, but we might need an example.

With #982 merged, in the next release you can use an interceptor to add this functionality. I'll post an example here once the docs are updated

@danvergara
Copy link
Author

@srikrsna-buf Nice!
Looking forward to it!

Thanks!

@srikrsna-buf
Copy link
Member

We just published a preview release with support for server side interceptors: npm i @connectrpc/connect@next.

The docs for interceptors are here.

@danvergara
Copy link
Author

Looking forward for the actual release!

In the meantime, I'll read the docs and telling my teammates that the solution to our current issue is on its way.

Thanks for the support @srikrsna-buf!!!

@danvergara danvergara changed the title Otel support just like otelconnect-go provides. Otel support just like otelconnect-go does Feb 12, 2024
@chrispine
Copy link
Contributor

Closing this issue, but feel free to re-open (or create a new issue) if needed. Thanks!

@danvergara
Copy link
Author

Well, I'd like to keep it open until v1.4.0 comes out. At least, I'd like to know how long until the next release. My CTO is asking me.

@chrispine
Copy link
Contributor

Sure, we can do that. Unsure of the release date at the moment, but I'll look into it.

@chrispine chrispine reopened this Feb 26, 2024
@danvergara
Copy link
Author

Thanks @chrispine
Really appreciated.

@chrispine
Copy link
Contributor

Here you go, @danvergara: https://github.com/connectrpc/connect-es/releases/tag/v1.4.0

I'll close this now, but as always, reach back out or re-open if needed. Thanks!

@danvergara
Copy link
Author

Thanks so much!!!!!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants