Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webkit support in docker image #916

Open
psadi opened this issue Nov 9, 2022 · 5 comments
Open

webkit support in docker image #916

psadi opened this issue Nov 9, 2022 · 5 comments
Labels
triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. type: feature

Comments

@psadi
Copy link

psadi commented Nov 9, 2022

What would you like?

Support for webkit & its dependencies baked into the the existing docker image

Why is this needed?

To have webkit support, This is useful for my use case as my org network doesn't connect to playwright's cdn

Other

No response

@psadi
Copy link
Author

psadi commented Dec 13, 2022

Any update on this ?

@brian-mann
Copy link
Member

There are really two concerns here - caching the browser version and adding the browser dependencies for webkit.

  1. Dependencies - we should definitely add the system dependencies for running webkit in our docker images like we do for Chrome + Firefox
  2. Versioning - I don't think we'll want to version webkit inside of the docker containers because that version is coupled to the @playwright/webkit NPM module. Instead we should update our installation instructions coaching you on how to cache this in CI yourself. You don't need the webkit binary in the docker container in order to add caching on top of it (this is the same principle as all other NPM dependencies)

@mikevitaler
Copy link

We are running into this issue as well when trying to run our Cypress suite of tests against webkit using the official Cypress docker image. Are there any workarounds for this issue at the moment?

@nagash77 nagash77 added the triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. label Apr 19, 2023
@jennifer-shehane
Copy link
Member

Transferring this issue to docker-images repo since this is concerned with our docket-images and not the Cypress App itself.

@jennifer-shehane jennifer-shehane transferred this issue from cypress-io/cypress Jul 14, 2023
@MikeMcC399
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. type: feature
Projects
None yet
Development

No branches or pull requests

7 participants