Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Migrate away from mobx decorators to avoid runtime implications in typescript configuration #30882

Open
AtofStryker opened this issue Jan 15, 2025 · 0 comments
Labels
type: chore Work is required w/ no deliverable to end user

Comments

@AtofStryker
Copy link
Contributor

What would you like?

Cypress would like to remove the use of mobx decorators as they are now opt-in in mobx version 6

Why is this needed?

To avoid heavy runtime implications of useDefineForClassFields, which is needed for mobx decorators. This caused issues when #30764 was introduced which removed the field and caused a failure we did not catch until the Cypress 14 bughunt. #30856 reverted the change. We would like to avoid as much runtime manipulation as possible, which is the rationale for migrating away from decorator patterns.

Original mobx update PR can be found in #30514

Other

No response

@jennifer-shehane jennifer-shehane added the type: chore Work is required w/ no deliverable to end user label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Work is required w/ no deliverable to end user
Projects
None yet
Development

No branches or pull requests

2 participants