fix: avoid source map plugin from replacing valid code #30890
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
The regex condition to find source map links would catch code that wasn't actually a source map link, but only looked like it.
A real source map link would always look like this:
//# sourceMappingURL=a-real-file-path.js
So I decided to refine the regex to ensure it doesn't match if there is a
'
or"
after the=
. Because valid source map URL's won't have these quotes, but these edge cases where this snippet is part of the code will have it.Steps to test
The broken behaviour can be reproduced by importing a JS file that looks like a source map link, but isn't actually one, e.g.:
How has the user experience changed?
There are no changes to the user experience, but some edge cases that previously would break will no longer break.
PR Tasks
cypress-documentation
?type definitions
?