Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: automatically infer cypress major version from package.json #30911

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

AtofStryker
Copy link
Contributor

Additional details

Automatically detects the major version of the Cypress package in order to display the splash page. If no splash page is added for the new major version, a test inside MajorVersionWelcome.cy.tsx will error alerting the team to add a test
Screenshot 2025-01-17 at 3 10 36 PM

Steps to test

How has the user experience changed?

PR Tasks

…rsion and error when no splash page exists for said major version
Copy link

cypress bot commented Jan 17, 2025

cypress    Run #59933

Run Properties:  status check cancelled Cancelled #59933  •  git commit 0fefa9d073: chore: automatically infer cypress major version from package.json version and e...
Project cypress
Branch Review chore/splash_page_autosource
Run status status check cancelled Cancelled #59933
Run duration 36m 17s
Commit git commit 0fefa9d073: chore: automatically infer cypress major version from package.json version and e...
Committer AtofStryker
View all properties for this run ↗︎

Test results
Tests that failed  Failures 21
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 343
Tests that did not run due to a failure in a mocha hook  Skipped 16
Tests that passed  Passing 3895
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  44.44%
  Untested elements 50  
  Tested elements 40  
Accessibility  96.15%
  Failed rules  0 critical   3 serious   0 moderate   0 minor
  Failed elements 110  

Tests for review

Failed  commands/traversals.cy.js • 0 failed tests • 5x-driver-firefox

View Output

Test Artifacts
Failed  commands/net_stubbing.cy.ts • 0 failed tests • 5x-driver-firefox

View Output

Test Artifacts
Failed  commands/actions/type_special_chars.cy.js • 0 failed tests • 5x-driver-firefox

View Output

Test Artifacts
Failed  commands/cookies.cy.js • 0 failed tests • 5x-driver-firefox

View Output

Test Artifacts
Failed  e2e/origin/cookie_behavior.cy.ts • 0 failed tests • 5x-driver-firefox

View Output

Test Artifacts

The first 5 failed specs are shown, see all 1194 specs in Cypress Cloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: automatically parse major version text when determining major version to show splash page
1 participant