Memory leak

[ThomasdenH]

Compiling with CFLAGS="-fsanitize=address" will reliably crash jpeg-hash with
the following image file:

[zvezdochiot]

jpeg-archive/src/hash.c

Lines 23 to 27 in 8da4bf7

	for (int y = 0; y < height; y++) {
	for (int x = 0; x < width; x++) {
	int pos = y * width + x;
	(*hash)[pos] = image[pos] < image[pos + 1];

pos < height * width
pos + 1 !< height * width

Maybe:

    int hw, pos;
    hw = height * width;
    for (pos = 0; pos < (hw - 1); pos++)
    {
        (*hash)[pos] = (image[pos] < image[pos + 1]);
    }
    (*hash)[hw - 1] = (image[hw - 1] < image[0]);

Not?

[zvezdochiot]

I will add one more such "miss", but already "from the side":

jpeg-archive/src/smallfry.c

Lines 74 to 81 in 8da4bf7

	for (i = 0; i < height; i++) {
	for (j = 7; j < width - 1; j += 8) {
	double calc;
	cnt++;
	calc = abs(DVAL(j) - DVAL(j + 1));
	calc /= (abs(DVAL(j - 1) - DVAL(j)) + abs(DVAL(j + 1) - DVAL(j + 2)) + 0.0001) / 2.0;

to:

 for (j = 7; j < width - 2; j += 8) {

jpeg-archive/src/smallfry.c

Lines 96 to 103 in 8da4bf7

	for (i = 7; i < height - 1; i += 8) {
	for (j = 0; j < width; j++) {
	double calc;
	cnt++;
	calc = abs(DVAL(j) - HDVAL(j, 1));
	calc /= (abs(HDVAL(j, -1) - DVAL(j)) + abs(HDVAL(j, 1) - HDVAL(j, 2)) + 0.0001) / 2.0;

to:

 for (i = 7; i < height - 2; i += 8) {

See https://github.com/ImageProcessing-ElectronicPublications/libsmallfry