Make traefik CRD installation flaggable

[gardleopard]

I'd like to make it possible to disable the CRD installation for traefik in the helmchart. This is for installation in clusters that already has traefik installed.

Is this a feature that would be accepted?

[jacobtomlinson]

Sounds reasonable to me. Is there any way to catch and warn about cases where folks disable it, but it's not installed already?

[gardleopard]

AFAIK it will break the helm install, as the cluster will not have the CRD definition that we try to upload.

[consideRatio]

There are various strategies to provide CRDs for heln charts i think.

1. By putting them in a crds folder (current situation)
   this leads to a one-off installation as part of the chart install (not upgrade), making users need to manually update the CRDs
2. By rendering them as other manifests part of the helm chart templates

I'm not confident on what makes sense etc, but the key is to overview if putting them as templates is relevant for existing users and/or new users, and how people should migrate etc between strategies.

[consideRatio]

I agree on the value of being able to opt-out at least on anything traefik-related, as they arent required to be deployed specifically by this chart - and since its a cluster-wide resource it will conflict with other traefik CRDs

[consideRatio]

Can one opt-out of installing a charts CRDs in the crds folder, using a helm CLI flag? If so, one could first opt out during the initial install, and then manually apply yhe dask-gateway specific CRDs as a workaround if better options aren't available for us.

[gardleopard]

I will make a PR with the ability to turn on and off traefik and can test how it works etc:) It will take a few days before I can do it.

[gardleopard]

I made a PR to make traefik installation optional. With the built in mechanisms of helm with regards to skipping installation of CRDs, I did not find a nice solution for opting out of traefik CRD installation while keeping the installation of the daskclusters.gateway.dask.orgCRD.