Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate back to mixins for Sencha Cmd and Architect compatibility #127

Open
johnyanarella opened this issue Nov 12, 2013 · 0 comments
Open

Comments

@johnyanarella
Copy link
Member

Sencha Cmd has introduced an optimizer step (now enabled by default for Ext JS apps) that does not support custom class preprocessors. Class preprocessors were recently marked as private and are no longer an encouraged extension mechanism for the Sencha frameworks; a class preprocessor effectively reserves certain keywords across an entire codebase.

The solution moving forward needs to be in alignment with the documented public Sencha Framework APIs, to ensure a solution that will be supported in the future.

We discussed this with Sencha at SenchaCon, and the recommendation was to move to mix-ins, as these are the supported extension mechanism.

This comes with a few added benefits:

  • it plays well with others - we're only reserving keywords within the class definition that has been decorated with that mix-in;
  • it plays well with Sencha Architect;
  • it eliminates several class dependency timing issues that tend to trip developers up when the first try Deft JS in their apps (ex. Ext.Component not being available at the time Deft JS is included, etc.).

Because this is the supported extension mechanism, in the event we have difficulty or need additional extension points, Sencha is more likely to assist in addressing those issues (as opposed to unsupported or undocumented approaches).

@ghost ghost assigned johnyanarella Nov 12, 2013
brian428 added a commit that referenced this issue Dec 4, 2013
… add an Observer mixin to handle observe features, mix it into base ViewController, and remove existing Observer-related code from ViewController. Also, try to remove Karma run for Ext JS 4.0.x from build, to prevent CI test failure.
brian428 added a commit that referenced this issue Dec 4, 2013
brian428 added a commit that referenced this issue Dec 17, 2013
…ests to exercise the config object option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant