v2 SMS Validation

[k-macmillan]

User Story - Business Need

Validate /legacy/v2/notifications/sms in the same manner notification-api validates them. Evaluating which follow-on tasks should be "chained" is not necessary.

• Sync with Kyle when ticket is picked up.
• Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)

As a VA Notify client
I want any upgrades to be seamless for me
So that I don't have to change for any VA Notify changes

Additional Info and Resources

Starts with post_notification in the notification-api.

• Validate (skip = not doing, defer = doing later)
  1. Template is of the right channel type: sms and is active
  2. Personalization matches template personalization (permissive, needs them if there, extra is ignored)
  3. defer: template is part of the service - will come when we have proper JWT auth and request state
  4. defer: rate limiting - will come later (only applies to dev/staging)
  5. defer: daily message limiting - will come later (only applies to dev/staging)
  6. skip: service has permission to send this channel of notification
  7. skip: template is active - no longer applicable
  8. skip: scheduled for - unused
  9. skip: sms sender default - all services have a default sms sender now

Acceptance Criteria

• SOLID principles
• route entrypoint calls a validate method
• All non-skipped/deffered methods validations in the Additional Info have methods written
• Other than identifying what to validate, no notification-api code is reused
• All validations involving the database are done against the notification-api read database
• This work is added to the sprint review slide deck (key win bullet point and demo slide)

QA Considerations

Endpoint log parity or identification of what will change so we can notify our clients (when we get far enough along to switch).

Potential Dependencies

• Definitely depends on notification-api Database Connection #114
• Pydantic Models -Legacy v2 SMS Pydantic Models #117

Out of Scope

• Evaluating chain tasks.
• Sending to Celery/SQS.

[cris-oddball]

@k-macmillan potentially dumb question, but does ENP have permissions to read from the notification-api database? Or do we need a ticket for that (upon which this ticket is dependent)?

[cris-oddball]

Nevermind, I'll add #114 to dependencies