Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENP Connect to ENP DB when Deployed #159

Open
6 tasks
EvanParish opened this issue Feb 3, 2025 · 2 comments
Open
6 tasks

ENP Connect to ENP DB when Deployed #159

EvanParish opened this issue Feb 3, 2025 · 2 comments
Assignees
Labels
Dev Reviewed Reviewed by Tech Lead Notify Board trigger PM Reviewed Reviewed by Product Manager QA Reviewed Reviewed by Quality Assurance QA Issue requires QA collaboration

Comments

@EvanParish
Copy link
Contributor

EvanParish commented Feb 3, 2025

User Story - Business Need

Currently the deployed ENP code cannot connect to the ENP database hosted in RDS. This requires some changes to how we construct the database uri. It will no longer be passed in a single environment variable and will need to be constructed from a few different ones, see Additional Info below.

  • Sync with Kyle when ticket is picked up.
  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)

As a backend engineer
I want to connect to the database when the application is deployed
So that the FastAPI codebase is useable when deployed

Additional Info and Resources

  • We will need to alter the code to build the database connection string based on the appropriate secrets. These secrets are available as environment variables.
    • DB_AUTH
    • DB_HOSTNAME
    • DB_HOSTNAME_READ

Acceptance Criteria

  • When ENP is deployed the code can connect to our ENP database in RDS
  • Local database connection is still intact for running the app locally
  • This work is added to the sprint review slide deck (key win bullet point and demo slide)

QA Considerations

  • Endpoints that rely on ENP database connections are able to execute successfully

The routes that rely on the ENP db are currently just:

  • GET and POST /db/test

Potential Dependencies

Out of Scope

@EvanParish EvanParish added Notify Board trigger QA Issue requires QA collaboration labels Feb 3, 2025
@cris-oddball
Copy link
Contributor

Requested changes from @EvanParish and added changes requested label.

We have two databases that enp needs to connect to, the ENP DB and the Notification-API DB. The epic that is it is in implies the notification-api DB but it's not clear to me.

@cris-oddball
Copy link
Contributor

Evan confirmed that this is for connecting to the ENP database.

@cris-oddball cris-oddball changed the title ENP Connect to DB when Deployed ENP Connect to ENP DB when Deployed Feb 7, 2025
@cris-oddball cris-oddball added QA Reviewed Reviewed by Quality Assurance and removed Changes Requested labels Feb 7, 2025
@k-macmillan k-macmillan added the Dev Reviewed Reviewed by Tech Lead label Feb 11, 2025
@cris-oddball cris-oddball mentioned this issue Feb 11, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Reviewed Reviewed by Tech Lead Notify Board trigger PM Reviewed Reviewed by Product Manager QA Reviewed Reviewed by Quality Assurance QA Issue requires QA collaboration
Projects
None yet
Development

No branches or pull requests

5 participants