Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force queue of VetCenter Facilities does not include all Outstations, mobiles or CAPS. #13768

Closed
4 tasks
swirtSJW opened this issue May 19, 2023 · 2 comments · Fixed by #14169
Closed
4 tasks
Assignees
Labels
Defect Something isn't working (issue type) Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Lighthouse Facility API Data source/destination for many Facilities team products sitewide

Comments

@swirtSJW
Copy link
Contributor

swirtSJW commented May 19, 2023

Describe the defect

When we force queue VetCetner facilities for a bulk push to lighthouse, it is only doing VetCenters and is not doing outstations, mobiles or CAPs (should not be pushing caps now, but once CAPS are in Facility API we neeed to).
image

All the logic lives here modules/custom/va_gov_post_api/src/Form/VaGovFacilityForceQueueForm.php

To Reproduce

Steps to reproduce the behavior:

  1. visit https://prod.cms.va.gov/admin/config/va-gov-post-api/facility-force-queue
  2. Notice that only Vet Cetnters are counted here. (code was not updated when we split vet centers into 3 types)

AC / Expected behavior

  • I expect that when I visit the force queue page, there are options for Outstations, VC mobile , and CAPs
  • I expect that the Outstation and mobile options force queue nodes in all states except archived.
  • I expect that the CAPs option only force queuing PUBLISHED CAPs. (node status = 1) Because they do not exist in the facility API until they are published in the CMS. CAPs need to wait for VACMS-13613 Add VetCenter CAP data push. #13777, per @swirtSJW on Slack.
  • I expect that the CAPs option clearly indicates that it is only force queuing PUBLISHED CAPs.

Screenshots

image

@swirtSJW swirtSJW added Defect Something isn't working (issue type) Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status Lighthouse Facility API Data source/destination for many Facilities team products labels May 19, 2023
@swirtSJW
Copy link
Contributor Author

This is blocked by #13769 because without 13769 we would be force pushing incorrect urls for these very facilities.

@swirtSJW
Copy link
Contributor Author

I merged the incomplete PR here because it fixed the related bug of not being able to force push anything.
#14102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Something isn't working (issue type) Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Lighthouse Facility API Data source/destination for many Facilities team products sitewide
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants