From 6391c7c95ebd5bb3ffc114ba5c6345fa8771af88 Mon Sep 17 00:00:00 2001 From: Sangjoon Bob Lee Date: Mon, 23 Sep 2024 09:25:44 -0400 Subject: [PATCH 1/4] Add unit test for version check --- tests/test_version.py | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 tests/test_version.py diff --git a/tests/test_version.py b/tests/test_version.py new file mode 100644 index 0000000..ecc61be --- /dev/null +++ b/tests/test_version.py @@ -0,0 +1,10 @@ +"""Unit tests for __version__.py +""" + +import diffpy.structure + + +def test_package_version(): + """Ensure the package version is defined and not set to the initial placeholder.""" + assert hasattr(diffpy.structure, '__version__'), "The package version is not defined." + assert diffpy.structure.__version__ != "0.0.0" From 4e212e4f9975785c2a7247b71efde3dcc44eb9e7 Mon Sep 17 00:00:00 2001 From: Sangjoon Bob Lee Date: Mon, 23 Sep 2024 09:27:09 -0400 Subject: [PATCH 2/4] Add unit test for version --- news/version-test.rst | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 news/version-test.rst diff --git a/news/version-test.rst b/news/version-test.rst new file mode 100644 index 0000000..05c3947 --- /dev/null +++ b/news/version-test.rst @@ -0,0 +1,23 @@ +**Added:** + +* Unit test for version.py + +**Changed:** + +* + +**Deprecated:** + +* + +**Removed:** + +* + +**Fixed:** + +* + +**Security:** + +* From 2df4a06417885a662a579971cb87eb6984f2bcfc Mon Sep 17 00:00:00 2001 From: Sangjoon Bob Lee Date: Mon, 23 Sep 2024 09:28:36 -0400 Subject: [PATCH 3/4] Remove failed msg for version attribute --- tests/test_version.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_version.py b/tests/test_version.py index ecc61be..b57eda2 100644 --- a/tests/test_version.py +++ b/tests/test_version.py @@ -6,5 +6,5 @@ def test_package_version(): """Ensure the package version is defined and not set to the initial placeholder.""" - assert hasattr(diffpy.structure, '__version__'), "The package version is not defined." + assert hasattr(diffpy.structure, '__version__') assert diffpy.structure.__version__ != "0.0.0" From 3473749a75c86e7fc57a82132f528772ae3546c8 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 23 Sep 2024 13:33:44 +0000 Subject: [PATCH 4/4] [pre-commit.ci] auto fixes from pre-commit hooks --- tests/test_version.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_version.py b/tests/test_version.py index b57eda2..e62433e 100644 --- a/tests/test_version.py +++ b/tests/test_version.py @@ -6,5 +6,5 @@ def test_package_version(): """Ensure the package version is defined and not set to the initial placeholder.""" - assert hasattr(diffpy.structure, '__version__') + assert hasattr(diffpy.structure, "__version__") assert diffpy.structure.__version__ != "0.0.0"