Make @include_using the default catch-all behavior #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the use of
@include_using
obsolete as it becomes the default when doing a catchall-import (e.g.@fromparent import *
).It now adds an equivalent opt out fake macro
@exclude_using
to have the 0.7 behavior where all names brought into the target scope withusing
statements are not imported with catch-all.As this is now by default re-exporting everything, this PR also added another step in the filtering process of names to import.
![image](https://private-user-images.githubusercontent.com/12846528/333879400-c32e53bd-3607-483c-9330-dad66a9b6a4a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMDk1NjIsIm5iZiI6MTczOTAwOTI2MiwicGF0aCI6Ii8xMjg0NjUyOC8zMzM4Nzk0MDAtYzMyZTUzYmQtMzYwNy00ODNjLTkzMzAtZGFkNjZhOWI2YTRhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDEwMDc0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg0ZDQ2MDE2NGJiNzhjYzAxNzYyNTVhOGIwZjczN2FjZGZlYTllZTg4MDMxNDY4ODRkYmUzMDJiNzFhMmJlMWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.dZqbEMVFCEwWVItCdc23b6eibos4RzYHtkpc1SBQ0RQ)
At the moment, whenever a name to be imported in the calling Pluto notebook is already defined (and not pointing to some value/function defined withint the previous version of the target package itself), it is skipped.
When there is a clash between a name to import an a name already existing in the caller module (which is tied to a different object than the one imported by the target package), a warning will be issued like below: