Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how extensions are loaded for target packages.
Since #50, we now have our target package loaded as root_module, which gives access to some more convenience functionality from Base.
Prior to this PR, the extensions code was parsed and loaded in the target module with custom functions defined in the package.
Now, the extensions are loaded by calling
Base.insert_extension_triggers
andBase.run_extension_callbacks
.To allow reloading extensions upon manual reload, we
hackily
remove the loaded extension fromBase.EXT_PRIMED
and fromBase.loaded_modules
so that it can be re-inserted byBase.run_extension_callbacks
.This should now support all the extensions functionality from julia itself, closing #39