Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor how extensions are loaded #55

Merged
merged 3 commits into from
May 31, 2024
Merged

refactor how extensions are loaded #55

merged 3 commits into from
May 31, 2024

Conversation

disberd
Copy link
Owner

@disberd disberd commented May 31, 2024

This PR changes how extensions are loaded for target packages.

Since #50, we now have our target package loaded as root_module, which gives access to some more convenience functionality from Base.

Prior to this PR, the extensions code was parsed and loaded in the target module with custom functions defined in the package.

Now, the extensions are loaded by calling Base.insert_extension_triggers and Base.run_extension_callbacks.
To allow reloading extensions upon manual reload, we hackily remove the loaded extension from Base.EXT_PRIMED and from Base.loaded_modules so that it can be re-inserted by Base.run_extension_callbacks.

This should now support all the extensions functionality from julia itself, closing #39

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1be5847) to head (c8131c4).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #55   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          820       771   -49     
=========================================
- Hits           820       771   -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@disberd disberd merged commit 0cbe1ec into master May 31, 2024
9 checks passed
@disberd disberd deleted the extensions_refactor branch June 4, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant