-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FTM: Add caching to ESContentFactoryImpl#findContentletByIdentifier to optimize queries with the publishDate parameter #31246
Comments
Now with FTM, each time we request a page in Live Mode, we are always sending a publish date. Please make sure we are not executing the logic related to FTM when the publish date/time is now . Consider a time lapse (I suggest 1-2 mins) in case there is a delay in the request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Parent Issue
No response
User Story
Currently, the method ESContentFactoryImpl#findContentletByIdentifier(final String identifier, final long languageId, final String variantId, final Date timeMachineDate) executes direct database queries when collections with the Time Machine feature are queried using the publishDate parameter set to a future date.
This behavior creates a vulnerability where malicious users could misuse URLs with the publishDate parameter to overload the database with unnecessary queries. To mitigate this risk, caching should be introduced for this method.
since FTM gets triggered by passing the publishDate param, add a condition to prevent FTM from getting triggered unless the publishDate is the present day including a specific time
if (publishDate == today && publishDate does not have time){
publishDate = null
}
Acceptance Criteria
Proposed Objective
Security & Privacy
Proposed Priority
Please Select
External Links... Slack Conversations, Support Tickets, Figma Designs, etc.
No response
Assumptions & Initiation Needs
No response
Quality Assurance Notes & Workarounds
No response
Sub-Tasks & Estimates
No response
The text was updated successfully, but these errors were encountered: