From 44d555d372e307dd05b9d8add825a2f40dfec52e Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Thu, 23 Jan 2025 11:41:22 +0100 Subject: [PATCH] Temporarily downgrade assembly reference load warnings to messages See https://github.com/dotnet/sdk/issues/46236 This is necessary to unblock dependency flow into runtime. --- .../AssemblySymbolLoader.cs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Compatibility/Microsoft.DotNet.ApiSymbolExtensions/AssemblySymbolLoader.cs b/src/Compatibility/Microsoft.DotNet.ApiSymbolExtensions/AssemblySymbolLoader.cs index 361937c6b18b..104c9ce41c18 100644 --- a/src/Compatibility/Microsoft.DotNet.ApiSymbolExtensions/AssemblySymbolLoader.cs +++ b/src/Compatibility/Microsoft.DotNet.ApiSymbolExtensions/AssemblySymbolLoader.cs @@ -420,8 +420,10 @@ private void ResolveReferences(PEReader peReader, string assemblyName, string ro if (!found) { - _log.LogWarning(AssemblyReferenceNotFoundErrorCode, - string.Format(Resources.CouldNotResolveReference, assemblyReferenceName, rootAssemblyDisplayString)); + // Temporarily downgrade assembly reference load warnings to messages: https://github.com/dotnet/sdk/issues/46236 + // _log.LogWarning(AssemblyReferenceNotFoundErrorCode, + // string.Format(Resources.CouldNotResolveReference, assemblyReferenceName, rootAssemblyDisplayString)); + _log.LogMessage(MessageImportance.High, string.Format(Resources.CouldNotResolveReference, assemblyReferenceName, rootAssemblyDisplayString)); } } }