Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APICompat: Log assembly reference resolve failures as warnings again #46236

Open
ViktorHofer opened this issue Jan 23, 2025 · 1 comment
Open

APICompat: Log assembly reference resolve failures as warnings again #46236

ViktorHofer opened this issue Jan 23, 2025 · 1 comment
Assignees
@ViktorHofer
Labels
Area-ApiCompat
Milestone
10.0.1xx

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 23, 2025 •
edited
Loading

This is necessary to unblock dotnet/runtime#111328

We should find a better heuristic so that we only log assembly reference load warnings when those assembly references are actually required for the assembly under test.

This affects both APICompat and GenAPI.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-ApiCompat untriaged Request triage from a team member labels Jan 23, 2025
@ViktorHofer ViktorHofer removed the untriaged Request triage from a team member label Jan 23, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

@dotnet/area-infrastructure-libraries a new issue has been filed in the ApiCompat area, please triage

ViktorHofer added a commit that referenced this issue Jan 23, 2025
@ViktorHofer
Temporarily downgrade assembly reference load warnings to messages
44d555d 
See #46236
This is necessary to unblock dependency flow into runtime.
This was referenced Jan 23, 2025
Merged
Closed
@ViktorHofer ViktorHofer added this to the 10.0.1xx milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ViktorHofer ViktorHofer

Labels
Area-ApiCompat
Projects
None yet
Milestone
10.0.1xx
Development

No branches or pull requests
1 participant
@ViktorHofer