Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tinygo missing vcs info #25

Open
bhelx opened this issue Nov 20, 2024 · 6 comments
Open

tinygo missing vcs info #25

bhelx opened this issue Nov 20, 2024 · 6 comments

Comments

@bhelx
Copy link
Contributor

bhelx commented Nov 20, 2024

When generating a new go plugin, and then going to run xtp plugin build:

[I] ben@dylibso ~/dlete> xtp plugin build
🔨 Building dist/plugin.wasm
Running build script: mkdir -p dist && tinygo build -target wasi -o dist/plugin.wasm .
error obtaining VCS status: exit status 128
	Use -buildvcs=false to disable VCS stamping.
Log file: /Users/ben/Library/Caches/xtp/xtp-1732118894-40444.log

-buildvcs=false seems to be an option on go, not tinygo. So i'm not sure how to set that. we could perhaps init a git repo in prepare.sh? or we can figure out how to get tinygo not to do this.

@nilslice
Copy link
Member

hm, I can't repro this. what tinygo version are you using? and what is inside dlete?

From my root, I just ran xtp plugin init, picked Go, changed into its directory and cleanly ran xtp plugin build

@bhelx
Copy link
Contributor Author

bhelx commented Nov 20, 2024

[I] ben@dylibso ~/dlete [1]> tinygo version
tinygo version 0.32.0 darwin/arm64 (using go version go1.22.5 and LLVM version 18.1.2)
[I] ben@dylibso ~/dlete> go version
go version go1.22.5 darwin/arm64

@bhelx
Copy link
Contributor Author

bhelx commented Nov 20, 2024

dlete is a freshly generated go plugin. nothing interesting in it. Running git init solves the error. deleting .git folder brings it back

@nilslice
Copy link
Member

super weird... I didn't have this issue with 0.32, and don't with the latest version at 0.34 either.

@nilslice
Copy link
Member

I am behind no big Go though, with go1.22.1 installed. I'll try updating and see if that changes anything.

@nilslice
Copy link
Member

I get the same result with no issue, using go1.23.3.

Wouldn't the problem you face happen on CI too if it were a typical problem? I've never seen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants