From 1779f0907ca90f75eac5b45aabb281ec25d1e6c4 Mon Sep 17 00:00:00 2001 From: Lukas Kalbertodt Date: Thu, 11 Jan 2024 09:55:24 +0100 Subject: [PATCH 1/2] Fix series block video items for screen widths 880 - 890 It was somewhat broken for those widths. One constant was also incorrectly named, which I fixed. I also slightly increased the sizes for large screens, because it didn't make a ton of sense to me that the numbers were larger for small screens. All these changes should be very small though. --- frontend/src/ui/Blocks/Series.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/frontend/src/ui/Blocks/Series.tsx b/frontend/src/ui/Blocks/Series.tsx index 0ff95a71f..fd39bbd5f 100644 --- a/frontend/src/ui/Blocks/Series.tsx +++ b/frontend/src/ui/Blocks/Series.tsx @@ -543,9 +543,9 @@ const Videos: React.FC = ({ basePath, items }) => { }); }; -const ITEM_MIN_SIZE = 240; -const ITEM_MIN_SIZE_LARGE_SCREENS = 260; -const ITEM_MAX_SIZE = 315; +const ITEM_MIN_SIZE = 250; +const ITEM_MIN_SIZE_SMALL_SCREENS = 240; +const ITEM_MAX_SIZE = 330; const ITEM_MAX_SIZE_SMALL_SCREENS = 360; const GalleryView: React.FC = ({ basePath, items }) => ( @@ -618,7 +618,7 @@ const GalleryView: React.FC = ({ basePath, items }) => ( columnGap: 12, rowGap: 28, [screenWidthAtMost(1600)]: { - gridTemplateColumns: `repeat(auto-fill, minmax(${ITEM_MIN_SIZE_LARGE_SCREENS}px, 1fr))`, + gridTemplateColumns: `repeat(auto-fill, minmax(${ITEM_MIN_SIZE_SMALL_SCREENS}px, 1fr))`, }, }}> {items.map(({ event, active }) => ( From cc066db0129f5939683e8f41aac9016548d713a8 Mon Sep 17 00:00:00 2001 From: Lukas Kalbertodt Date: Thu, 11 Jan 2024 09:58:52 +0100 Subject: [PATCH 2/2] Fix debug warning about non-camelCase emotion property This results in the correct `-webkit-text-size-adjust: none` in the resulting CSS. Addresses part of #1070. --- frontend/src/GlobalStyle.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/GlobalStyle.tsx b/frontend/src/GlobalStyle.tsx index bc4d3b2a3..b4fd4de32 100644 --- a/frontend/src/GlobalStyle.tsx +++ b/frontend/src/GlobalStyle.tsx @@ -53,7 +53,7 @@ const CSS_RESETS = css({ // This prevents an increase in font size when changing from // portrait to landscape orientation in iOS safari. - "-webkit-text-size-adjust": "none", + WebkitTextSizeAdjust: "none", }, // This improves the readability of underlines in links.