Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe get rid of log.log_http_headers config #1291

Closed
LukasKalbertodt opened this issue Dec 5, 2024 · 1 comment
Closed

Maybe get rid of log.log_http_headers config #1291

LukasKalbertodt opened this issue Dec 5, 2024 · 1 comment
Milestone

Comments

@LukasKalbertodt
Copy link
Member

This is a pretty ad-hoc specific config, mainly to debug setting up an auth system. For some time now, we have a fairly flexible filter system for logging, where logging levels can be set per module path. We could just do the header logging in a new dummy module and then remove the config option.

mod header_logging {
    fn log(req: &Request) { ... }
}

It makes the code a bit more meh, but gets rid of one config option by integrating it into a more flexible solution, which is nice. 🤷

@LukasKalbertodt LukasKalbertodt added this to the v3.0 milestone Dec 5, 2024
owi92 added a commit that referenced this issue Dec 19, 2024
…es (#1309)

This rather ad-hoc random config option was weird. Now two noisy log
messages can be individually filtered by moving them to separate
submodules. This changes the default when just setting `filters.tobira =
"trace`" in that now, HTTP headers are also printed. But I think that's
totally fine.

Fixes #1291
@LukasKalbertodt
Copy link
Member Author

Fixed in #1309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant